chore: suppress PostCSS warning and enhance logger
#36
Conversation
Enhanced logger with timestamps, colors, and dynamic log levels. Suppressed PostCSS warning in dev and updated ESLint rules.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @bniladridas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on improving the developer experience by cleaning up the console output and modernizing the logging system. It addresses a persistent PostCSS warning by implementing a custom Vite plugin and significantly enhances the shared logger with features like timestamps, colored output, and configurable log levels. Additionally, it refines ESLint rules to be more flexible with unused parameters and adjusts PostCSS dependencies for better compatibility. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several good changes, including suppressing a noisy PostCSS warning, modernizing the logger, and improving ESLint configuration. The changes are generally well-implemented. I've provided a few suggestions to improve type safety, maintainability, and robustness in the logger and Vite configuration. Specifically, I've recommended using a more specific type for error handling, refactoring the logger to avoid code duplication, and using Vite's dedicated logger API instead of monkey-patching the global console.
vite.config.ts
Outdated
| configureServer(_server) { | ||
| const originalWarn = console.warn; | ||
| console.warn = (message, ...args) => { | ||
| if (message.includes('PostCSS plugin did not pass the `from` option')) | ||
| return; | ||
| originalWarn(message, ...args); | ||
| }; | ||
| }, |
There was a problem hiding this comment.
Monkey-patching the global console.warn is risky as it can affect other parts of your application or dependencies in unexpected ways, and makes debugging harder. A safer approach is to modify Vite's specific logger instance, which is provided as the server argument in the configureServer hook.
Additionally, it's good practice to check if the message is a string before calling string methods on it to prevent potential runtime errors, as the first argument to console.warn is not guaranteed to be a string.
configureServer(server) {
const originalWarn = server.logger.warn;
server.logger.warn = (message, ...args) => {
if (
typeof message === 'string' &&
message.includes('PostCSS plugin did not pass the `from` option')
) {
return;
}
originalWarn(message, ...args);
};
},
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
… duplicate logic Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
bniladridas
changed the title
PostCSS warning and enhance logger
Summary
Suppress the noisy PostCSS dev warning and modernize logging behavior.
Changes
_param)getCurrentLogLevelValuehelper and remove duplicate logicResult
Cleaner dev console output with all checks passing and no functional regressions.